feat(s3stream): optimization handler chain #1726
Conversation
CLFutureX
requested review from
superhx,
SCNieh,
ShadowySpirits and
Chillax-0v0
as code owners
| @@ -128,7 +128,7 @@ public class S3Storage implements Storage { | |||
|
|
|||
| @SuppressWarnings("this-escape") | |||
| public S3Storage(Config config, WriteAheadLog deltaWAL, StreamManager streamManager, ObjectManager objectManager, | |||
| S3BlockCache blockCache, ObjectStorage objectStorage, StorageFailureHandler storageFailureHandler) { | |||
There was a problem hiding this comment.
Why S3Storage need to know the storage failure handle is a StorageHandlerChain?
There was a problem hiding this comment.
Why S3Storage need to know the storage failure handle is a StorageHandlerChain?
Based on the current constructor method with the handler parameter, it gives the impression that only a single handler implementation class needs to be executed, whereas in reality, S3Storage requires the execution of multiple handler implementation classes.
There was a problem hiding this comment.
Why S3Storage need to know the storage failure handle is a StorageHandlerChain?
The root cause lies in the fact that the current design does not distinguish between 'chain' and 'handler' (that is, the chain of responsibility has not been distinguished from the nodes on the chain of responsibility), with differentiation made only in naming.
|
This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please ask a committer for review. If the PR has merge conflicts, please update it with the latest from trunk (or appropriate release branch) If this PR is no longer valid or desired, please feel free to close it. If no activity occurs in the next 30 days, it will be automatically closed. |
issue